linux-kernel - Re: [PATCH 2/3] firmware: psci: Add support for dt-supplied SYSTEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Feb 2020 09:59:03 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Elliot Berman <eberman@...eaurora.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Trilok Soni <tsoni@...eaurora.org>,
        Prasad Sodagudi <psodagud@...eaurora.org>,
        David Collins <collinsd@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] firmware: psci: Add support for dt-supplied
 SYSTEM_RESET2 type

Hi Elliot,

I have dropped the wrong mailing list you had used. The right one is
linux-arm-kernel@...ts.infradead.org. I won't add now as it makes no
sense to just have the response there without the patch.

On Fri, Feb 21, 2020 at 03:28:04PM -0800, Elliot Berman wrote:
> Some implementors of PSCI may relax the requirements of the PSCI
> architectural warm reset. In order to comply with PSCI specification, a
> different reset_type value must be used. The alternate PSCI
> SYSTEM_RESET2 may be used in all warm/soft reboot scenarios, replacing
> the architectural warm reset.
> 
> Signed-off-by: Elliot Berman <eberman@...eaurora.org>
> ---
>  drivers/firmware/psci/psci.c | 21 +++++++++++++++++----
>  include/linux/psci.h         |  1 +
>  include/uapi/linux/psci.h    |  2 ++
>  3 files changed, 20 insertions(+), 4 deletions(-)
>

[...]


>  /*
> diff --git a/include/linux/psci.h b/include/linux/psci.h
> index a67712b..1959a80 100644
> --- a/include/linux/psci.h
> +++ b/include/linux/psci.h
> @@ -37,6 +37,7 @@ struct psci_operations {
>  	int (*migrate_info_type)(void);
>  	enum arm_smccc_conduit conduit;
>  	enum smccc_version smccc_version;
> +	u32 sys_reset2_reset_type;

Why this needs to be in this header ? Can't it be just local to psci.c ?

-- 
Regards,
Sudeep