linux-kernel - Re: [PATCH 5/5] arm64/vdso: Restrict splitting VVAR VMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <248ddd41-d3b3-05f2-4e49-177236726209@arm.com>
Date:   Mon, 24 Feb 2020 10:08:08 +0000
From:   Vincenzo Frascino <vincenzo.frascino@....com>
To:     Andrei Vagin <avagin@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Dmitry Safonov <dima@...sta.com>
Subject: Re: [PATCH 5/5] arm64/vdso: Restrict splitting VVAR VMA

Hi Andrei,

On 2/23/20 11:30 PM, Andrei Vagin wrote:
[...]

> 
> Hmmm. I have read the code of special_mapping_mremap() and I don't see where
> it restricts splitting the vvar mapping.
> 
> Here is the code what I see in the source:
> 
> static int special_mapping_mremap(struct vm_area_struct *new_vma)
> {
>         struct vm_special_mapping *sm = new_vma->vm_private_data;
> 
>         if (WARN_ON_ONCE(current->mm != new_vma->vm_mm))
>                 return -EFAULT;
> 
>         if (sm->mremap)
>                 return sm->mremap(sm, new_vma);
> 
>         return 0;
> }
> 
> And I have checked that without this patch, I can remap only one page of
> the vvar mapping.
>

I checked it a second time and I agree. The check on new_size is required in
this case.

> Thanks,
> Andrei
> 

-- 
Regards,
Vincenzo