linux-kernel - Re: [RFC PATCH v3 4/8] regulator: rename regulator_linear_range to linear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d66373944b9afa9e2387d7bf95deb9d997906396.camel@fi.rohmeurope.com>
Date:   Mon, 24 Feb 2020 12:20:11 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "broonie@...nel.org" <broonie@...nel.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "sbkim73@...sung.com" <sbkim73@...sung.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "wens@...e.org" <wens@...e.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "rf@...nsource.cirrus.com" <rf@...nsource.cirrus.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "tony@...mide.com" <tony@...mide.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "b.zolnierkie@...sung.com" <b.zolnierkie@...sung.com>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "patches@...nsource.cirrus.com" <patches@...nsource.cirrus.com>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "Mutanen, Mikko" <Mikko.Mutanen@...rohmeurope.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "milo.kim@...com" <milo.kim@...com>,
        "agross@...nel.org" <agross@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Laine, Markus" <Markus.Laine@...rohmeurope.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "sre@...nel.org" <sre@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "ckeepax@...nsource.cirrus.com" <ckeepax@...nsource.cirrus.com>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "andrei.stefanescu@...rochip.com" <andrei.stefanescu@...rochip.com>,
        "support.opensource@...semi.com" <support.opensource@...semi.com>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: Re: [RFC PATCH v3 4/8] regulator: rename regulator_linear_range to
 linear_range

Hello Mark,

On Mon, 2020-02-24 at 11:53 +0000, Mark Brown wrote:
> On Thu, Feb 20, 2020 at 09:36:10AM +0200, Matti Vaittinen wrote:
> > Rename the "regulator_linear_range" to more generic linear_range
> > as a first step towards converting the "regulator_linear_range"
> > to common helpers.
> 
> Doesn't this introduce a build break when applied by itself?  Patches
> should be bisectable, if you want to split things up you should
> introduce the new API then use it.

Uh, I need to double check but this shouldn't cause build break as only
the name of the struct is changed - and I intended to change it both in
regulator header and in all of the drivers using it at same time. Or
did I do some brainfart here?

I just wanted to minimize the changes in patch with the widest
audience.

Oh, after rebasing to linux  5.6-rc2 I see that there are few new users
of regulator_linear_range (I should have known that...) - natuarlly all
of the users need to be covered before applying this.

Br,
	Matti Vaittinen