linux-kernel - Re: [PATCH] KVM: X86: eliminate some meaningless code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ddaeeccac5664e2a9ba570952585a474@huawei.com>
Date:   Mon, 24 Feb 2020 01:54:19 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>
CC:     "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH] KVM: X86: eliminate some meaningless code

Paolo Bonzini <pbonzini@...hat.com> wrote:
>On 21/02/20 16:23, Sean Christopherson wrote:
>> 
>> I'm guessing no VMM actually uses this ioctl(), e.g. neither Qemu or 
>> CrosVM use it, which is why the broken behavior has gone unnoticed.  
>> Don't suppose you'd want to write a selftest to hammer KVM_{SET,GET}_CPUID2?
>> 
>
>I would just drop KVM_GET_CPUID2 altogether and see if someone complains.
>

Will do. Thanks.