linux-kernel - Re: [PATCH v2 4/9] arm64: dts: librem5-devkit: allow modem to wake the system from suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200224020251.GF27688@dragon>
Date:   Mon, 24 Feb 2020 10:02:52 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     robh@...nel.org, mark.rutland@....com, s.hauer@...gutronix.de,
        kernel@...gutronix.de, linux-imx@....com, Anson.Huang@....com,
        devicetree@...r.kernel.org, kernel@...i.sm,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        "Angus Ainslie (Purism)" <angus@...ea.ca>
Subject: Re: [PATCH v2 4/9] arm64: dts: librem5-devkit: allow modem to wake
 the system from suspend

On Tue, Feb 18, 2020 at 09:49:37AM +0100, Martin Kepplinger wrote:
> From: "Angus Ainslie (Purism)" <angus@...ea.ca>
> 
> Connect the WoWWAN signal to a gpio key to wake up the system from suspend.
> 
> Signed-off-by: Angus Ainslie (Purism) <angus@...ea.ca>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>
> ---
>  .../arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index ec12477d925d..9c81b07f43f3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -55,6 +55,15 @@
>  			wakeup-source;
>  			linux,code = <KEY_HP>;
>  		};
> +
> +		wwan_wake {

We prefer to use hyphen over underscore in node name.

Shawn

> +			label = "WWAN_WAKE";
> +			gpios = <&gpio3 8 GPIO_ACTIVE_LOW>;
> +			interrupt-parent = <&gpio3>;
> +			interrupts = <8 GPIO_ACTIVE_LOW>;
> +			wakeup-source;
> +			linux,code = <KEY_PHONE>;
> +		};
>  	};
>  
>  	leds {
> @@ -574,6 +583,7 @@
>  			MX8MQ_IOMUXC_SAI2_RXFS_GPIO4_IO21	0x16
>  			MX8MQ_IOMUXC_SAI2_RXC_GPIO4_IO22	0x16
>  			MX8MQ_IOMUXC_SAI5_RXC_GPIO3_IO20	0x180  /* HP_DET */
> +			MX8MQ_IOMUXC_NAND_DATA02_GPIO3_IO8	0x80   /* nWoWWAN */
>  		>;
>  	};
>  
> -- 
> 2.20.1
>