linux-kernel - Re: [PATCH] net: core: devlink.c: Use built-in RCU list checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202002240820.cbyN0Rb5%lkp@intel.com>
Date:   Mon, 24 Feb 2020 08:28:24 +0800
From:   kbuild test robot <lkp@...el.com>
To:     madhuparnabhowmik10@...il.com
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        jiri@...lanox.com, davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, joel@...lfernandes.org,
        frextrite@...il.com,
        linux-kernel-mentees@...ts.linuxfoundation.org, paulmck@...nel.org,
        Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
Subject: Re: [PATCH] net: core: devlink.c: Use built-in RCU list checking

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master v5.6-rc2 next-20200221]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/madhuparnabhowmik10-gmail-com/net-core-devlink-c-Use-built-in-RCU-list-checking/20200223-035655
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 732a0dee501f9a693c9a711730838129f4587041
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (git://gitmirror/llvm_project 1df947ab403a9ec3bb1bf4cd83610a997dc4f3bc)
reproduce:
        # FIXME the reproduce steps for clang is not ready yet

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> net/core/devlink.c:2111:22: error: use of undeclared identifier 'devlink'
                                   lockdep_is_held(&devlink->lock)) {
                                                    ^
   1 error generated.

vim +/devlink +2111 net/core/devlink.c

  2103	
  2104	static struct devlink_dpipe_table *
  2105	devlink_dpipe_table_find(struct list_head *dpipe_tables,
  2106				 const char *table_name)
  2107	{
  2108		struct devlink_dpipe_table *table;
  2109	
  2110		list_for_each_entry_rcu(table, dpipe_tables, list,
> 2111					lockdep_is_held(&devlink->lock)) {
  2112			if (!strcmp(table->name, table_name))
  2113				return table;
  2114		}
  2115		return NULL;
  2116	}
  2117	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (72192 bytes)