linux-kernel - Re: [PATCH v2 1/8] x86, syscalls: Refactor SYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200225194219.GA3954@light.dominikbrodowski.net>
Date:   Tue, 25 Feb 2020 20:42:19 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     Brian Gerst <brgerst@...il.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>
Subject: Re: [PATCH v2 1/8] x86, syscalls: Refactor SYSCALL_DEFINEx macros

Thanks for the updated series! Looks nicer to me now.

> +#ifdef CONFIG_X86_64
> +#define __X64_SYS_STUBx(x, sys_name, ...)				\
> +	__SYS_STUBx(x64, sys_name,					\
> +		    SC_X86_64_REGS_TO_ARGS(x, __VA_ARGS__))

I'd say it's easier to read if "name" is passed to this macro, and it is
expanded to sys_##name only within this macro...

> +#define __IA32_COMPAT_SYS_STUBx(x, compat_sys_name, ...)		\
> +	__SYS_STUBx(ia32, compat_sys_name,				\
> +		    SC_IA32_REGS_TO_ARGS(x, __VA_ARGS__))

... and in particular here (with compat_sys)

> +#define __IA32_SYS_STUBx(x, sys_name, ...)				\
> +	__SYS_STUBx(ia32, sys_name,					\
> +		    SC_IA32_REGS_TO_ARGS(x, __VA_ARGS__))

... same here

> +#define __X32_COMPAT_SYS_STUBx(x, compat_sys_name, ...)			\
> +	__SYS_STUBx(x32, compat_sys_name,				\
> +		    SC_X86_64_REGS_TO_ARGS(x, __VA_ARGS__))

... and here.

Otherwise, a nice cleanup!

Thanks,
	Dominik