linux-kernel - Re: [PATCH v2] xfs: fix an undefined behaviour in _da3_path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200225220527.GX6740@magnolia>
Date:   Tue, 25 Feb 2020 14:05:27 -0800
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Qian Cai <cai@....pw>
Cc:     Christoph Hellwig <hch@...radead.org>, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] xfs: fix an undefined behaviour in _da3_path_shift

On Tue, Feb 25, 2020 at 04:55:56PM -0500, Qian Cai wrote:
> 
> 
> > On Feb 25, 2020, at 4:40 PM, Christoph Hellwig <hch@...radead.org> wrote:
> > 
> > In xfs_da3_path_shift() blk can be assigned to state->path.blk[-1] if
> > state->path.active is 1 (which is a valid state) when it tries to add an
> > entry > to a single dir leaf block and then to shift forward to see if
> > there's a sibling block that would be a better place to put the new
> > entry.  This causes a KASAN warning given
> 
> s/KASAN/UBSAN/
> 
> > negative array indices are
> > undefined behavior in C.  In practice the warning is entirely harmless
> > given that blk is never dereference in this case, but it is still better
> > to fix up the warning and slightly improve the code.
> 
> Agree. This is better.
> 
> Darrick, do you need me to send a v3 for it or you could squash this in?

Please send a v3.  The code in v2 looked fine to me.

--D