linux-kernel - Re: [PATCH] phy: tegra: xusb: Don't warn on probe defer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7292f4cc-ec5c-4840-3627-72883a0353c7@ti.com>
Date:   Tue, 25 Feb 2020 10:32:14 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jon Hunter <jonathanh@...dia.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] phy: tegra: xusb: Don't warn on probe defer

Hi Thierry,

On 24/02/20 8:42 pm, Thierry Reding wrote:
> On Mon, Feb 24, 2020 at 02:36:41PM +0000, Jon Hunter wrote:
>> Deferred probe is an expected return value for tegra_fuse_readl().
>> Given that the driver deals with it properly, there's no need to
>> output a warning that may potentially confuse users.
>>
>> Signed-off-by: Jon Hunter <jonathanh@...dia.com>
>> ---
>>  drivers/phy/tegra/xusb-tegra186.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Kishon,
> 
> I already have a couple of PHY subsystem patches from JC and Nagarjuna
> in a branch in the Tegra tree that I need to resolve a dependency. Do
> you mind if I pick this up into that branch as well and send it to you
> as a pull request later on? Say around v5.6-rc6?

You can take this via Tegra tree itself.

Acked-by: Kishon Vijay Abraham I <kishon@...com>

-Kishon

> 
> Alternatively you could provide an Acked-by and then I can take them all
> through ARM SoC.
> 
> Thierry
> 
>> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
>> index 84c27394c181..12d0f3e30dbc 100644
>> --- a/drivers/phy/tegra/xusb-tegra186.c
>> +++ b/drivers/phy/tegra/xusb-tegra186.c
>> @@ -802,7 +802,9 @@ tegra186_xusb_read_fuse_calibration(struct tegra186_xusb_padctl *padctl)
>>  
>>  	err = tegra_fuse_readl(TEGRA_FUSE_SKU_CALIB_0, &value);
>>  	if (err) {
>> -		dev_err(dev, "failed to read calibration fuse: %d\n", err);
>> +		if (err != -EPROBE_DEFER)
>> +			dev_err(dev, "failed to read calibration fuse: %d\n",
>> +				err);
>>  		return err;
>>  	}
>>  
>> -- 
>> 2.17.1
>>