linux-kernel - Re: [PATCH 2/7] gcov_seq_next should increase position index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eda4c5d3-81fe-3970-9fc5-f9bc7b1c5bd8@virtuozzo.com>
Date:   Tue, 25 Feb 2020 09:36:31 +0300
From:   Vasily Averin <vvs@...tuozzo.com>
To:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Peter Oberparleiter <oberpar@...ux.ibm.com>
Subject: Re: [PATCH 2/7] gcov_seq_next should increase position index

Dear Andrew,
Could you please pick up this patch too?

On 1/30/20 4:09 PM, Peter Oberparleiter wrote:
> On 24.01.2020 08:02, Vasily Averin wrote:
>> if seq_file .next fuction does not change position index,
>> read after some lseek can generate unexpected output.
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=206283
>> Signed-off-by: Vasily Averin <vvs@...tuozzo.com>
> 
> Acked-by: Peter Oberparleiter <oberpar@...ux.ibm.com>
> 
>> ---
>>  kernel/gcov/fs.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
>> index e5eb5ea..cc4ee48 100644
>> --- a/kernel/gcov/fs.c
>> +++ b/kernel/gcov/fs.c
>> @@ -108,9 +108,9 @@ static void *gcov_seq_next(struct seq_file *seq, void *data, loff_t *pos)
>>  {
>>  	struct gcov_iterator *iter = data;
>>  
>> +	(*pos)++;
>>  	if (gcov_iter_next(iter))
>>  		return NULL;
>> -	(*pos)++;
>>  
>>  	return iter;
>>  }
>>
> 
>