linux-kernel - Re: [PATCH -next] drivers: net: WIREGUARD depends on IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9rWq+jJk5s+OoQ+MFMg74=b-a+LtJFjNWqLg6fcreLKbA@mail.gmail.com>
Date:   Tue, 25 Feb 2020 14:52:47 +0800
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Chen Zhou <chenzhou10@...wei.com>
Cc:     davem@...emloft.net, jiri@...lanox.com, krzk@...nel.org,
        gregkh@...uxfoundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drivers: net: WIREGUARD depends on IPV6

On 2/25/20, Chen Zhou <chenzhou10@...wei.com> wrote:
> If CONFIG_IPV6 is n, build fails:
>
> drivers/net/wireguard/device.o: In function `wg_xmit':
> device.c:(.text+0xb2d): undefined reference to `icmpv6_ndo_send'
> make: *** [vmlinux] Error 1
>
> Set WIREGUARD depending on IPV6 to fix this.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
> ---
>  drivers/net/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 25a8f93..824292e 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -74,7 +74,7 @@ config DUMMY
>  config WIREGUARD
>  	tristate "WireGuard secure network tunnel"
>  	depends on NET && INET
> -	depends on IPV6 || !IPV6
> +	depends on IPV6

Thanks for reporting the breakage. However, this is not the correct
fix, as wireguard should work without IPv6. Rather, the recent icmp
fixes changed something. I'll investigate why when I'm off the road in
several hours.