linux-kernel - Re: [PATCH] dma: imx-sdma: Fix the event id check to include RX event for UART6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3940d827-2886-5507-4a52-d97e572ce0d2@kontron.de>
Date:   Tue, 25 Feb 2020 08:03:25 +0000
From:   Schrempf Frieder <frieder.schrempf@...tron.de>
To:     Vinod Koul <vkoul@...nel.org>, Fabio Estevam <festevam@...il.com>
CC:     Dan Williams <dan.j.williams@...el.com>,
        Linus Walleij <linus.ml.walleij@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dma: imx-sdma: Fix the event id check to include RX event
 for UART6

On 25.02.20 07:12, Vinod Koul wrote:
> On 24-02-20, 15:43, Fabio Estevam wrote:
>> Hi Frieder,
>>
>> On Mon, Feb 24, 2020 at 2:22 PM Schrempf Frieder
>> <frieder.schrempf@...tron.de> wrote:
>>>
>>> From: Frieder Schrempf <frieder.schrempf@...tron.de>
>>>
>>> On i.MX6 the DMA event for the RX channel of UART6 is '0'. To fix
>>
>> I would suggest being a bit more specific than saying i.MX6.
>>
>> I see UART6 is present on i.MX6UL/i.MX6SX, but not on i.MX6Q/i.MX6DL,
>> so it would be better to specify it in the commit log.
>>
>> imx6ul.dtsi does not have dma nodes under uart6, so I guess you fixed
>> it for imx6sx.
> 
> and use right subsystem tag dmaengine. Git log of the file should tell
> you the right one to use :)

Sorry, my bad. I will fix it.

> 
>>
>>> the broken DMA support for UART6, we change the check for event_id0
>>> to include '0' as a valid id.
>>>
>>> Fixes: 1ec1e82f2510 ("dmaengine: Add Freescale i.MX SDMA support")
>>> Cc: stable@...r.kernel.org
>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
>>
>> Reviewed-by: Fabio Estevam <festevam@...il.com>
>