linux-kernel - Re: [PATCH 27/30] habanalabs: Add missing annotation for goya_hw_queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Feb 2020 13:55:50 +0200
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Jules Irenge <jbi.octave@...il.com>
Cc:     boqun.feng@...il.com,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tomer Tayar <ttayar@...ana.ai>,
        Omer Shpigelman <oshpigelman@...ana.ai>,
        Dalit Ben Zoor <dbenzoor@...ana.ai>
Subject: Re: [PATCH 27/30] habanalabs: Add missing annotation for goya_hw_queues_lock()

On Mon, Feb 24, 2020 at 1:18 AM Jules Irenge <jbi.octave@...il.com> wrote:
>
> Sparse reports a warning at goya_hw_queues_lock()
> warning: context imbalance in goya_hw_queues_lock() - wrong count at exit
> The root cause is a missing annotation at goya_hw_queues_lock()
> Add the missing __acquires(&goya->hw_queues_lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@...il.com>
> ---
>  drivers/misc/habanalabs/goya/goya.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
> index 7344e8a222ae..8ca7ee57cbc1 100644
> --- a/drivers/misc/habanalabs/goya/goya.c
> +++ b/drivers/misc/habanalabs/goya/goya.c
> @@ -5073,6 +5073,7 @@ static bool goya_is_device_idle(struct hl_device *hdev, u32 *mask,
>  }
>
>  static void goya_hw_queues_lock(struct hl_device *hdev)
> +       __acquires(&goya->hw_queues_lock)
>  {
>         struct goya_device *goya = hdev->asic_specific;
>
> --
> 2.24.1
>
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@...il.com>
Applied to -next
Thanks,
Oded