linux-kernel - Re: [PATCH 3/4] ARM: dts: axp813: Add charger LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d7c078b-362d-6eab-0915-8079768a729e@ti.com>
Date:   Tue, 25 Feb 2020 06:56:39 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Ondrej Jirman <megous@...ous.com>, <linux-sunxi@...glegroups.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Maxime Ripard <mripard@...nel.org>
CC:     Mark Rutland <mark.rutland@....com>,
        Lee Jones <lee.jones@...aro.org>, <linux-leds@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 3/4] ARM: dts: axp813: Add charger LED

Ondrej

On 2/23/20 7:14 AM, Ondrej Jirman wrote:
> PMIC supports charging status indication via a LED. Add support
> for it.
>
> Signed-off-by: Ondrej Jirman <megous@...ous.com>
> ---
>   arch/arm/boot/dts/axp81x.dtsi | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
> index 1dfeeceabf4c3..00b092f94433d 100644
> --- a/arch/arm/boot/dts/axp81x.dtsi
> +++ b/arch/arm/boot/dts/axp81x.dtsi
> @@ -175,4 +175,9 @@ reg_drivevbus: drivevbus {
>   	usb_power_supply: usb-power-supply {
>   		compatible = "x-powers,axp813-usb-power-supply";
>   	};
> +
> +	charger_led: charger-led {
> +		compatible = "x-powers,axp813-charger-led";
> +		status = "disabled";

As I commented before you need to add function and color to this node 
and read it from the driver.  Or you can add them to the over ride for 
the specific use case.

Another question is is this LED only used for charging or can it be 
multi purpose?

Dan


> +	};
>   };