linux-kernel - Re: [PATCH -next] drm/amd/powerplay: Use bitwise instead of arithmetic operator for flags

Open Source and information security mailing list archives

Message-ID: <CADnq5_OZgyYrkPSna0Sp+04-POYxWqgXgOPkjGfgxz2qCqiTwA@mail.gmail.com>
Date:   Tue, 25 Feb 2020 10:13:56 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     "Quan, Evan" <Evan.Quan@....com>
Cc:     Chen Zhou <chenzhou10@...wei.com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "Feng, Kenneth" <Kenneth.Feng@....com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/amd/powerplay: Use bitwise instead of
 arithmetic operator for flags

On Sun, Feb 23, 2020 at 10:21 PM Quan, Evan <Evan.Quan@....com> wrote:
>
> Thanks. Reviewed-by: Evan Quan <evan.quan@....com>
>

Applied.  Thanks!

Alex

> -----Original Message-----
> From: Chen Zhou <chenzhou10@...wei.com>
> Sent: Friday, February 21, 2020 8:22 PM
> To: Quan, Evan <Evan.Quan@....com>; Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian <Christian.Koenig@....com>; Zhou, David(ChunMing) <David1.Zhou@....com>; airlied@...ux.ie; daniel@...ll.ch
> Cc: Feng, Kenneth <Kenneth.Feng@....com>; amd-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; chenzhou10@...wei.com
> Subject: [PATCH -next] drm/amd/powerplay: Use bitwise instead of arithmetic operator for flags
>
> This silences the following coccinelle warning:
>
> "WARNING: sum of probable bitmasks, consider |"
>
> Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index 92a65e3d..f29f95b 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -3382,7 +3382,7 @@ static int vega10_populate_and_upload_sclk_mclk_dpm_levels(
>         }
>
>         if (data->need_update_dpm_table &
> -                       (DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_UPDATE_SCLK + DPMTABLE_UPDATE_SOCCLK)) {
> +                       (DPMTABLE_OD_UPDATE_SCLK | DPMTABLE_UPDATE_SCLK |
> +DPMTABLE_UPDATE_SOCCLK)) {
>                 result = vega10_populate_all_graphic_levels(hwmgr);
>                 PP_ASSERT_WITH_CODE((0 == result),
>                                 "Failed to populate SCLK during PopulateNewDPMClocksStates Function!", @@ -3390,7 +3390,7 @@ static int vega10_populate_and_upload_sclk_mclk_dpm_levels(
>         }
>
>         if (data->need_update_dpm_table &
> -                       (DPMTABLE_OD_UPDATE_MCLK + DPMTABLE_UPDATE_MCLK)) {
> +                       (DPMTABLE_OD_UPDATE_MCLK | DPMTABLE_UPDATE_MCLK)) {
>                 result = vega10_populate_all_memory_levels(hwmgr);
>                 PP_ASSERT_WITH_CODE((0 == result),
>                                 "Failed to populate MCLK during PopulateNewDPMClocksStates Function!",
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives