linux-kernel - Re: [PATCH v4 9/9] power: supply: Support ROHM bd99954 charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c187bb77-e804-93bd-64db-9418be58f191@infradead.org>
Date:   Tue, 25 Feb 2020 08:21:33 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        mazziesaccount@...il.com
Cc:     Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Markus Laine <markus.laine@...rohmeurope.com>,
        Mikko Mutanen <mikko.mutanen@...rohmeurope.com>
Subject: Re: [PATCH v4 9/9] power: supply: Support ROHM bd99954 charger

On 2/25/20 12:55 AM, Matti Vaittinen wrote:
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 8781c674ed07..0b3bad6fc736 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -702,6 +702,16 @@ config CHARGER_BD70528
>  	 information and altering charger configurations from charger
>  	 block of the ROHM BD70528 Power Management IC.
>  

Hi,

> +config CHARGER_BD99954
> +	tristate "ROHM bd99954 charger driver"
> +	depends on I2C
> +	select LINEAR_RANGES
> +	default n

Drop the "default n", since it is already the default.

> +	help
> +	 Say Y here to enable support for getting battery and charger
> +	 information and altering charger configurations from the ROHM
> +	 BD99954 charger IC.

Please indent the 3 lines of help text with one additional space (2 total).
See Documentation/process/coding-style.rst:

10) Kconfig configuration files
-------------------------------

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.  Example::

  config AUDIT
	bool "Auditing support"
	depends on NET
	help
	  Enable auditing infrastructure that can be used with another
	  kernel subsystem, such as SELinux (which requires this for
	  logging of avc messages output).  Does not do system-call
	  auditing without CONFIG_AUDITSYSCALL.

> +
>  config CHARGER_WILCO
>  	tristate "Wilco EC based charger for ChromeOS"
>  	depends on WILCO_EC

thanks.
-- 
~Randy