linux-kernel - Re: [PATCH 01/12] dt-bindings: bus: ti-sysc: Add support for PRUSS SYSC type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200226183132.GV37466@atomide.com>
Date:   Wed, 26 Feb 2020 10:31:32 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Suman Anna <s-anna@...com>, Rob Herring <robh@...nel.org>
Cc:     Roger Quadros <rogerq@...com>, Tero Kristo <t-kristo@...com>,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 01/12] dt-bindings: bus: ti-sysc: Add support for PRUSS
 SYSC type

* Suman Anna <s-anna@...com> [200226 16:39]:
> Hi Roger,
> 
> On 2/26/20 2:42 AM, Roger Quadros wrote:
> > Hi Suman,
> > 
> > On 25/02/2020 22:46, Suman Anna wrote:
> >> From: Roger Quadros <rogerq@...com>
> >>
> >> The PRUSS module has a SYSCFG which is unique. The SYSCFG
> >> has two additional unique fields called STANDBY_INIT and
> >> SUB_MWAIT in addition to regular IDLE_MODE and STANDBY_MODE
> >> fields. Add the bindings for this new sysc type.
> >>
> >> Signed-off-by: Roger Quadros <rogerq@...com>
> >> Signed-off-by: Suman Anna <s-anna@...com>
> >> ---
> >>   Documentation/devicetree/bindings/bus/ti-sysc.txt | 1 +
> >>   include/dt-bindings/bus/ti-sysc.h                 | 4 ++++
> >>   2 files changed, 5 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> b/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> index 233eb8294204..c984143d08d2 100644
> >> --- a/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> +++ b/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> @@ -38,6 +38,7 @@ Required standard properties:
> >>           "ti,sysc-dra7-mcasp"
> >>           "ti,sysc-usb-host-fs"
> >>           "ti,sysc-dra7-mcan"
> >> +        "ti,sysc-pruss"
> >>     - reg        shall have register areas implemented for the
> >> interconnect
> >>           target module in question such as revision, sysc and syss
> >> diff --git a/include/dt-bindings/bus/ti-sysc.h
> >> b/include/dt-bindings/bus/ti-sysc.h
> > 
> > Did you intentionally leave this here? It should be part of 2nd patch?
> 
> No, not really, include/bindings are also considered part of bindings.
> This patch alone should be enough for you to add the DT nodes.

Well I don't care either way, sort of would prefer to have this
with the device patch in case somebody starts back porting
driver changes.

Anyways, let's wayt for Rob's ack on this, maybe he has also
preference on the ti-sysc.h changes.

Regards,

Tony