linux-kernel - Re: [PATCH v9 3/4] soc: mediatek: Move mt8173 MMSYS to platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da1b0908ddac65d370609f35c78d4a618ac70268.camel@collabora.com>
Date:   Wed, 26 Feb 2020 17:29:35 -0300
From:   Ezequiel Garcia <ezequiel@...labora.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        robh+dt@...nel.org, mark.rutland@....com, ck.hu@...iatek.com,
        p.zabel@...gutronix.de, airlied@...ux.ie, mturquette@...libre.com,
        sboyd@...nel.org, ulrich.hecht+renesas@...il.com,
        laurent.pinchart@...asonboard.com
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        dri-devel@...ts.freedesktop.org, Weiyi Lu <weiyi.lu@...iatek.com>,
        Seiya Wang <seiya.wang@...iatek.com>,
        linux-clk@...r.kernel.org,
        Collabora Kernel ML <kernel@...labora.com>,
        mtk01761 <wendell.lin@...iatek.com>,
        Allison Randal <allison@...utok.net>,
        Thomas Gleixner <tglx@...utronix.de>, wens@...e.org,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Houlong Wei <houlong.wei@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        sean.wang@...iatek.com, frank-w@...lic-files.de,
        Minghsiu Tsai <minghsiu.tsai@...iatek.com>,
        Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
        linux-mediatek@...ts.infradead.org, hsinyi@...omium.org,
        Matthias Brugger <mbrugger@...e.com>,
        linux-arm-kernel@...ts.infradead.org,
        Richard Fontana <rfontana@...hat.com>,
        linux-kernel@...r.kernel.org, matthias.bgg@...nel.org,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH v9 3/4] soc: mediatek: Move mt8173 MMSYS to platform
 driver

On Wed, 2020-02-26 at 07:40 -0800, Randy Dunlap wrote:
> On 2/26/20 2:54 AM, Enric Balletbo i Serra wrote:
> > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> > index 2114b563478c..dcd6481a14d0 100644
> > --- a/drivers/soc/mediatek/Kconfig
> > +++ b/drivers/soc/mediatek/Kconfig
> > @@ -44,4 +44,11 @@ config MTK_SCPSYS
> >  	  Say yes here to add support for the MediaTek SCPSYS power domain
> >  	  driver.
> >  
> > +config MT8173_MMSYS
> > +	bool "MediaTek MT8173 MMSYS Support"
> 
> Hi,
> Can this be tristate instead of bool?
> 

Wouldn't that conflict with
the driver being a builtin_platform_driver,
or am I just confusing things badly?

Thanks,
Ezequiel

> +	depends on COMMON_CLK_MT8173
> > +	help
> > +	  Say yes here to add support for the MediaTek MT8173 Multimedia
> > +	  Subsystem (MMSYS).
> > +
> >  endmenu
> 
> thanks.
> -- 
> ~Randy
> 
>