linux-kernel - Re: [PATCH] arm64: dts: sc7180: Move venus node to the correct position

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200226204436.GG24720@google.com>
Date:   Wed, 26 Feb 2020 12:44:36 -0800
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Dikshita Agarwal <dikshita@...eaurora.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: sc7180: Move venus node to the correct
 position

On Wed, Feb 26, 2020 at 12:40:23PM -0800, Doug Anderson wrote:
> Hi,
> 
> On Wed, Feb 26, 2020 at 11:40 AM Matthias Kaehlcke <mka@...omium.org> wrote:
> >
> > Per convention device nodes for SC7180 should be ordered by address.
> > This is currently not the case for the venus node, move it to the
> > correct position.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> > ---
> >
> >  arch/arm64/boot/dts/qcom/sc7180.dtsi | 52 ++++++++++++++--------------
> >  1 file changed, 26 insertions(+), 26 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > index 253274d5f04c..5f97945e16a4 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > @@ -1332,6 +1332,32 @@ system-cache-controller@...0000 {
> >                         interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;
> >                 };
> >
> > +               venus: video-codec@...0000 {
> > +                       compatible = "qcom,sc7180-venus";
> > +                       reg = <0 0x0aa00000 0 0xff000>;
> > +                       interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> > +                       power-domains = <&videocc VENUS_GDSC>,
> > +                                       <&videocc VCODEC0_GDSC>;
> > +                       power-domain-names = "venus", "vcodec0";
> > +                       clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
> > +                                <&videocc VIDEO_CC_VENUS_AHB_CLK>,
> > +                                <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>,
> > +                                <&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
> > +                                <&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
> > +                       clock-names = "core", "iface", "bus",
> > +                                     "vcodec0_core", "vcodec0_bus";
> > +                       iommus = <&apps_smmu 0x0c00 0x60>;
> > +                       memory-region = <&venus_mem>;
> > +
> > +                       video-decoder {
> > +                               compatible = "venus-decoder";
> > +                       };
> > +
> > +                       video-encoder {
> > +                               compatible = "venus-encoder";
> > +                       };
> > +               };
> > +
> >                 usb_1: usb@...8800 {
> >                         compatible = "qcom,sc7180-dwc3", "qcom,dwc3";
> >                         reg = <0 0x0a6f8800 0 0x400>;
> 
> Maybe try one more time?
> 
> >>> print [hex(x) for x in sorted([0x0aa00000, 0x0a6f8800])]
> ['0xa6f8800', '0xaa00000']
> 
> ...makes me convinced that the codec should come _after_ the USB node, no?

indeed, thanks for catching it!