linux-kernel - Re: [PATCH v2] dt-bindings: mmc: Convert Cadence SD/SDIO/eMMC controller to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Feb 2020 16:23:11 -0600
From:   Rob Herring <robh@...nel.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        masahiroy@...nel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Piotr Sroka <piotrs@...ence.com>,
        Mark Rutland <mark.rutland@....com>,
        Ulf Hansson <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mmc: Convert Cadence SD/SDIO/eMMC
 controller to json-schema

On Sat, 22 Feb 2020 23:34:44 +0900, Masahiro Yamada wrote:
> Convert the Cadence SD/SDIO/eMMC host controller IP (a.k.a. SD4HC)
> binding to DT schema format.
> 
> Socionext UniPhier ARM 64-bit SoCs are integrated with this IP.
> 
> Cc: Piotr Sroka <piotrs@...ence.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
> I wanted to keep some precious comments, which apply to multiple
> properties.
> 
> I do not think 'description:' is a good fit for this.
> 
> I was searching for a way to insert a comment line that does not
> affect the schema.
> 
> The $comment did not work. I just use '#', which is YAML comment.
> If there is a better way, please let me know.
> 
> 
> Changes in v2:
>   - fix schema warning in example
> 
>  .../devicetree/bindings/mmc/cdns,sdhci.yaml   | 143 ++++++++++++++++++
>  .../devicetree/bindings/mmc/sdhci-cadence.txt |  80 ----------
>  2 files changed, 143 insertions(+), 80 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>  delete mode 100644 Documentation/devicetree/bindings/mmc/sdhci-cadence.txt
> 

Applied, thanks.

Rob