linux-kernel - Re: [PATCH] x86/tsc: Add kernel options to disable CPUID and MSR calibrations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k149nd4p.fsf@nanos.tec.linutronix.de>
Date:   Thu, 27 Feb 2020 00:27:02 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Peter Zijlstra <peterz@...radead.org>,
        Prarit Bhargava <prarit@...hat.com>
Cc:     linux-kernel@...r.kernel.org,
        Patrick Geary <patrickg@...ermicro.com>,
        Jonathan Corbet <corbet@....net>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
        Juergen Gross <jgross@...e.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Daniel Drake <drake@...lessm.com>,
        Michael Zhivich <mzhivich@...mai.com>,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH] x86/tsc: Add kernel options to disable CPUID and MSR calibrations

Peter Zijlstra <peterz@...radead.org> writes:
> On Wed, Feb 26, 2020 at 11:43:08AM -0500, Prarit Bhargava wrote:
>> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
>> index dbc22d684627..0316aadfff08 100644
>> --- a/Documentation/admin-guide/kernel-parameters.txt
>> +++ b/Documentation/admin-guide/kernel-parameters.txt
>> @@ -4942,7 +4942,7 @@
>>  			See Documentation/admin-guide/mm/transhuge.rst
>>  			for more details.
>>  
>> -	tsc=		Disable clocksource stability checks for TSC.
>> +	tsc=option[,option...]	Various TSC options.
>>  			Format: <string>
>>  			[x86] reliable: mark tsc clocksource as reliable, this
>>  			disables clocksource verification at runtime, as well
>> @@ -4960,6 +4960,12 @@
>>  			in situations with strict latency requirements (where
>>  			interruptions from clocksource watchdog are not
>>  			acceptable).
>> +			[x86] no_cpuid_calibration: Disable the CPUID TSC
>> +			calibration.  Used in situations where the CPUID
>> +			TSC khz does not match the actual CPU TSC khz
>> +			[x86] no_msr_calibration: Disable the MSR TSC
>> +			calibration.  Used in situations where the MSR
>> +			TSC khz does not match the actual CPU TSC khz.
>
> Do we want to mention that these situations are mostly broken firmware?
> Also do mention that if you disable these you might not boot due to not
> having a PIT/HPET at all?

Right. Same discussion as before.

Also why do we want no_cpuid_calibration and no_msr_calibration? How
should Joe User figure out which one to use? This does not make
sense. The point is that the BIOS/Firmware supplied value in system
registers is bogus. So something like "skip_firmware_calibration" might
be better suitable.

Aside of that this really wants to be combined with the ability to
supply the actual frequency on the command line as I suggested in the
other thread to cope with machines which do not expose PIT/HPET or have
broken variants of them.

Thanks,

        tglx