linux-kernel - Re: [PATCH 01/12] dt-bindings: bus: ti-sysc: Add support for PRUSS SYSC type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96ec493b-3615-e84d-ba30-cabbf750c874@ti.com>
Date:   Wed, 26 Feb 2020 10:42:55 +0200
From:   Roger Quadros <rogerq@...com>
To:     Suman Anna <s-anna@...com>, Tony Lindgren <tony@...mide.com>
CC:     Tero Kristo <t-kristo@...com>, <linux-omap@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH 01/12] dt-bindings: bus: ti-sysc: Add support for PRUSS
 SYSC type

Hi Suman,

On 25/02/2020 22:46, Suman Anna wrote:
> From: Roger Quadros <rogerq@...com>
> 
> The PRUSS module has a SYSCFG which is unique. The SYSCFG
> has two additional unique fields called STANDBY_INIT and
> SUB_MWAIT in addition to regular IDLE_MODE and STANDBY_MODE
> fields. Add the bindings for this new sysc type.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>
> Signed-off-by: Suman Anna <s-anna@...com>
> ---
>   Documentation/devicetree/bindings/bus/ti-sysc.txt | 1 +
>   include/dt-bindings/bus/ti-sysc.h                 | 4 ++++
>   2 files changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/bus/ti-sysc.txt b/Documentation/devicetree/bindings/bus/ti-sysc.txt
> index 233eb8294204..c984143d08d2 100644
> --- a/Documentation/devicetree/bindings/bus/ti-sysc.txt
> +++ b/Documentation/devicetree/bindings/bus/ti-sysc.txt
> @@ -38,6 +38,7 @@ Required standard properties:
>   		"ti,sysc-dra7-mcasp"
>   		"ti,sysc-usb-host-fs"
>   		"ti,sysc-dra7-mcan"
> +		"ti,sysc-pruss"
>   
>   - reg		shall have register areas implemented for the interconnect
>   		target module in question such as revision, sysc and syss
> diff --git a/include/dt-bindings/bus/ti-sysc.h b/include/dt-bindings/bus/ti-sysc.h

Did you intentionally leave this here? It should be part of 2nd patch?

> index babd08a1d226..76b07826ed05 100644
> --- a/include/dt-bindings/bus/ti-sysc.h
> +++ b/include/dt-bindings/bus/ti-sysc.h
> @@ -18,6 +18,10 @@
>   
>   #define SYSC_DRA7_MCAN_ENAWAKEUP	(1 << 4)
>   
> +/* PRUSS sysc found on AM33xx/AM43xx/AM57xx */
> +#define SYSC_PRUSS_SUB_MWAIT		(1 << 5)
> +#define SYSC_PRUSS_STANDBY_INIT		(1 << 4)
> +
>   /* SYSCONFIG STANDBYMODE/MIDLEMODE/SIDLEMODE supported by hardware */
>   #define SYSC_IDLE_FORCE			0
>   #define SYSC_IDLE_NO			1
> 

-- 
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki