linux-kernel - [PATCH] media: rcar_drif: Do not print error in case of EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200226101420.9066-1-peter.ujfalusi@ti.com>
Date:   Wed, 26 Feb 2020 12:14:20 +0200
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     <mchehab@...nel.org>, <hverkuil-cisco@...all.nl>,
        <rashanmu@...il.com>
CC:     <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-renesas-soc@...r.kernel.org>
Subject: [PATCH] media: rcar_drif: Do not print error in case of EPROBE_DEFER for dma channel

If the dma channel request error code is EPROBE_DEFER there is no need to
print error message.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
---
Hi Hans,

the patch updates the v1 "media: rcar_drif: Use dma_request_chan() instead
dma_request_slave_channel()" which got applied to the v3 state.

I have not added the fixes line, but if you think the hash is not going to
change, you can copy this line:
Fixes: 1b5482e0d268 ("media: rcar_drif: Use dma_request_chan() instead dma_request_slave_channel()")

Regards,
Peter

 drivers/media/platform/rcar_drif.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/rcar_drif.c b/drivers/media/platform/rcar_drif.c
index 02ee0e2a09e9..3d2451ac347d 100644
--- a/drivers/media/platform/rcar_drif.c
+++ b/drivers/media/platform/rcar_drif.c
@@ -277,8 +277,12 @@ static int rcar_drif_alloc_dmachannels(struct rcar_drif_sdr *sdr)
 
 		ch->dmach = dma_request_chan(&ch->pdev->dev, "rx");
 		if (IS_ERR(ch->dmach)) {
-			rdrif_err(sdr, "ch%u: dma channel req failed\n", i);
 			ret = PTR_ERR(ch->dmach);
+			if (ret != -EPROBE_DEFER)
+				rdrif_err(sdr,
+					  "ch%u: dma channel req failed: %pe\n",
+					  i, ch->dmach);
+			ch->dmach = NULL;
 			goto dmach_error;
 		}
 
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki