linux-kernel - Re: [PATCH 2/3] sched/debug: Bunch up printing formats in common macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <32939f53-3916-07d5-c92b-1b57339dfe65@arm.com>
Date:   Wed, 26 Feb 2020 10:15:15 +0000
From:   Valentin Schneider <valentin.schneider@....com>
To:     Tao Zhou <t1zhou@...yun.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...nel.org,
        peterz@...radead.org, vincent.guittot@...aro.org,
        Dietmar.Eggemann@....com, patrick.bellasi@...bug.net,
        qais.yousef@....com
Subject: Re: [PATCH 2/3] sched/debug: Bunch up printing formats in common
 macros



On 26/02/2020 07:21, Tao Zhou wrote:
>> @@ -963,8 +962,7 @@ void proc_sched_show_task(struct task_struct *p, struct pid_namespace *ns,
>>  
>>  		t0 = cpu_clock(this_cpu);
>>  		t1 = cpu_clock(this_cpu);
>> -		SEQ_printf(m, "%-45s:%21Ld\n",
>> -			   "clock-delta", (long long)(t1-t0));
>> +		__PS("clock-delta", t1-t0);
> 
>         __PS("clock-delta", (t1-t0));

Oh snap indeed! I think I may just as well shove parentheses in the macro
definitions.

Thanks.

> 
> Thanks,
> Tao
>>  	}
>>  
>>  	sched_show_numa(p, m);
>> -- 
>> 2.24.0
>>