linux-kernel - Re: [PATCH v2 1/3] dt: psci: Add arm,psci-sys-reset2-type property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200226120918.GA21897@lakrids.cambridge.arm.com>
Date:   Wed, 26 Feb 2020 12:09:19 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     Elliot Berman <eberman@...eaurora.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Trilok Soni <tsoni@...eaurora.org>,
        Prasad Sodagudi <psodagud@...eaurora.org>,
        David Collins <collinsd@...eaurora.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt: psci: Add arm,psci-sys-reset2-type property

On Mon, Feb 24, 2020 at 12:57:36PM -0800, Elliot Berman wrote:
> Some implementors of PSCI may relax the requirements of the PSCI
> architectural warm reset. In order to comply with PSCI specification, a
> different reset_type value must be used.

This reads as-if you're saying the firmware isn't spec compliant, and
this is a workaround in order to get the expected behaviour.

Can you please elaborate on what you mean by "relax the requirements"
here? What's your firmware doing or not doing that you want to avoid?

> The alternate PSCI SYSTEM_RESET2 may be used in all warm/soft reboot
> scenarios, replacing the architectural warm reset.

I assume you mean SYSTEM_REET2's SYSTEM_WARM_RESET reset? Please call
that out explicitly by name -- it makes this easier to look up, and
if/when more architectural resets are added the commit message won't
become ambiguous.

> 
> Signed-off-by: Elliot Berman <eberman@...eaurora.org>
> ---
>  Documentation/devicetree/bindings/arm/psci.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml
> index 8ef8542..469256a2 100644
> --- a/Documentation/devicetree/bindings/arm/psci.yaml
> +++ b/Documentation/devicetree/bindings/arm/psci.yaml
> @@ -102,6 +102,11 @@ properties:
>        [1] Kernel documentation - ARM idle states bindings
>          Documentation/devicetree/bindings/arm/idle-states.txt
>  
> +  arm,psci-sys-reset2-param:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +        reset_param value to use during a warm or soft reboot.

A "soft" reboot isn't a PSCI concept, so I'm worried this is just
hooking up magic values for Linux internals.

I'd like to better understand what you're trying to achieve here.

Thanks,
Mark.

> +
>    "#power-domain-cells":
>      description:
>        The number of cells in a PM domain specifier as per binding in [3].
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project