linux-kernel - Re: [PATCH v2 5/8] usb: mausb_host: Introduce PAL processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1582726796.17520.28.camel@suse.com>
Date:   Wed, 26 Feb 2020 15:19:56 +0100
From:   Oliver Neukum <oneukum@...e.com>
To:     Vladimir Stankovic <vladimir.stankovic@...playlink.com>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-usb <linux-usb@...r.kernel.org>,
        mausb-host-devel <mausb-host-devel@...playlink.com>
Subject: Re: [PATCH v2 5/8] usb: mausb_host: Introduce PAL processing

Hi,

+       atomic_inc(&urb->use_count);
+
+       mausb_print_urb(urb);
+
+       /*
+        * Masking URB_SHORT_NOT_OK flag as SCSI driver is adding it where it
+        * should not, so it is breaking the USB drive on the linux
+        */
+       urb->transfer_flags &= ~URB_SHORT_NOT_OK;

This is extremely drastic and will break drivers. Which driver causes
the problems?

	Regards
		Oliver