linux-kernel - Re: [PATCH] sched/fair: Fix unused prototype warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200226150723.GD3818@techsingularity.net>
Date:   Wed, 26 Feb 2020 15:07:23 +0000
From:   Mel Gorman <mgorman@...hsingularity.net>
To:     Valentin Schneider <valentin.schneider@....com>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>
Subject: Re: [PATCH] sched/fair: Fix unused prototype warning

On Wed, Feb 26, 2020 at 12:12:44PM +0000, Valentin Schneider wrote:
> Building against the latest tip/sched/core
> 
>   a0f03b617c3b ("sched/numa: Stop an exhastive search if a reasonable swap candidate or idle CPU is found")
> 
> with the arm64 defconfig (which doesn't have CONFIG_SCHED_SMT set) leads
> to:
> 
>   kernel/sched/fair.c:1525:20: warning: ???test_idle_cores??? declared ???static??? but never defined [-Wunused-function]
>    static inline bool test_idle_cores(int cpu, bool def);
> 		      ^~~~~~~~~~~~~~~
> 
> Rather than define it in its own CONFIG_SCHED_SMT #define island, bunch it
> up with test_idle_cores().
> 
> Signed-off-by: Valentin Schneider <valentin.schneider@....com>

Acked-by: Mel Gorman <mgorman@...hsingularity.net>

Ingo, what is your preferred method for dealing with this situation
in tip? A resubmission of "sched/numa: Stop an exhastive search if a
reasonable swap candidate or idle CPU is found" with these folded together
or Valentin's patch on top?

-- 
Mel Gorman
SUSE Labs