linux-kernel - Re: [PATCH v2 3/4] tpm: Implement tpm2_init to call when TPM_OPS_AUTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c31ef080-1172-e10b-e7b1-ab8e1682c860@linux.ibm.com>
Date:   Wed, 26 Feb 2020 12:35:17 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        linux-integrity@...r.kernel.org, aik@...abs.ru,
        david@...son.dropbear.id.au, linux-kernel@...r.kernel.org,
        nayna@...ux.vnet.ibm.com, gcwilson@...ux.ibm.com, jgg@...pe.ca
Subject: Re: [PATCH v2 3/4] tpm: Implement tpm2_init to call when
 TPM_OPS_AUTO_STARTUP is not set

On 2/26/20 10:02 AM, Jarkko Sakkinen wrote:
> On Tue, Feb 25, 2020 at 01:20:39PM -0500, Stefan Berger wrote:
>> On 2/25/20 12:00 PM, Jarkko Sakkinen wrote:
>>> On Thu, Feb 13, 2020 at 03:23:28PM -0500, Stefan Berger wrote:
>>>> From: Stefan Berger <stefanb@...ux.ibm.com>
>>>>
>>>> Implement tpm2_init() that gets the TPM 2 timeouts and command durations
>>>> and command code attributes. This function is to be called in case the
>>>> TPM_OPS_AUTO_STARTUP flag is not set and therefore tpm2_auto_startup()
>>>> is not called.
>>>>
>>>> Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
>>> The commit makes zero effort trying to explain what the heck tpm_init()
>>> is and when it should be used and why the function name tpm2_init().
>> Are you saying the explanation of when to use tpm2_init above is not enough?
>> 'bviously we are trying to cover the case of using the TPM 2 by a driver
>> that doesn't use the TPM_OPS_AUTO_STARTUP flag and therefore the TPM 2
>> timeouts and command durations and command code attributes are not set as
>> they would be if tpm2_auto_startup() was to be called and tpm2_init() is the
>> alternative to call. I didn't like tpm2_init() either... any suggestions for
>> a better name?
> I'm not getting what this commit is trying to do in the first place.
I sent out v3, maybe the text there is better.
>
> /Jarkko