linux-kernel - Re: [PATCH v6 0/9] net: fix sysfs permssions when device changes network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200226.190644.1695114419188031888.davem@davemloft.net>
Date:   Wed, 26 Feb 2020 19:06:44 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     gregkh@...uxfoundation.org
Cc:     christian.brauner@...ntu.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, rafael@...nel.org, pavel@....cz,
        kuba@...nel.org, edumazet@...gle.com, stephen@...workplumber.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v6 0/9] net: fix sysfs permssions when device changes
 network

From: David Miller <davem@...emloft.net>
Date: Wed, 26 Feb 2020 17:37:50 -0800 (PST)

> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Date: Wed, 26 Feb 2020 09:17:57 +0100
> 
>> On Tue, Feb 25, 2020 at 02:19:29PM +0100, Christian Brauner wrote:
>>> Hey everyone,
>>> 
>>> /* v6 */
>>> This is v6 with two small fixups. I missed adapting the commit message
>>> to reflect the renamed helper for changing the owner of sysfs files and
>>> I also forgot to make the new dpm helper static inline.
>> 
>> All of the sysfs and driver core bits look good to me now.  Thanks for
>> taking the time to update the documentation and other bits based on
>> reviews.
>> 
>> So now it's just up to the netdev developers to review the netdev parts :)
>> 
>> The sysfs and driver core patches can all go through the netdev tree to
>> make it easier for you.
> 
> I'm fine with these changes, and will apply this series to net-next.

Actually, you'll need to respin this with these warnings fixed, thanks:

fs/sysfs/group.c: In function ‘sysfs_group_change_owner’:
fs/sysfs/group.c:517:9: warning: unused variable ‘gid’ [-Wunused-variable]
  kgid_t gid;
         ^~~
fs/sysfs/group.c:516:9: warning: unused variable ‘uid’ [-Wunused-variable]
  kuid_t uid;
         ^~~