linux-kernel - Re: [PATCH v2 1/8] bootconfig: Set CONFIG_BOOT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200227092732.6a22a71a@gandalf.local.home>
Date:   Thu, 27 Feb 2020 09:27:32 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v2 1/8] bootconfig: Set CONFIG_BOOT_CONFIG=n by default

On Thu, 27 Feb 2020 10:22:00 +0100
Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

> > +
> > +static int __init warn_bootconfig(char *str)
> > +{
> > +       pr_warn("WARNING: 'bootconfig' found on the kernel command line but CONFIG_BOOTCONFIG is not set.\n");
> > +       return 0;
> > +}
> > +early_param("bootconfig", warn_bootconfig);  
> 
> Yeah, let's increases kernel size for the people who don't want to jump
> on the bootconfig wagon :-(
> 
> Is this really needed?

Yes, because if someone adds bootconfig to the command line they would be
expecting their bootconfig to be read. If not, we should not fail silently.

Are you really concerned about a tiny __init function that gets freed after
boot up?

-- Steve