linux-kernel - Re: [PATCH v5] leds: add SGI IP30 led support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200227150004.97154811ecbd2f5ccc22fa64@suse.de>
Date:   Thu, 27 Feb 2020 15:00:04 +0100
From:   Thomas Bogendoerfer <tbogendoerfer@...e.de>
To:     Pavel Machek <pavel@....cz>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Dan Murphy <dmurphy@...com>, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v5] leds: add SGI IP30 led support

On Wed, 26 Feb 2020 15:00:58 +0100
Pavel Machek <pavel@....cz> wrote:

> > +	switch (num) {
> > +	case IP30_LED_SYSTEM:
> > +		data->cdev.name = "white:system";
> > +		break;
> > +	case IP30_LED_FAULT:
> > +		data->cdev.name = "red:fault";
> > +		break;
> 
> If the white LED normally serves as power indicator for the system, we
> might want to specify that. Does it?

it could be seen as such, but it will be turned on only after POST has finished
successfull. So it's off if POST failed, which doesn't make it a real power led
IMHO.

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Felix Imendörffer