[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200227135243.GI108283@ediswmail.ad.cirrus.com>
Date: Thu, 27 Feb 2020 13:52:43 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Marek Szyprowski <m.szyprowski@...sung.com>
CC: <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
Mark Brown <broonie@...nel.org>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Lee Jones <lee.jones@...aro.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v2 1/2] mfd: wm8994: Fix driver operation if loaded as
modules
On Wed, Feb 26, 2020 at 11:08:01AM +0100, Marek Szyprowski wrote:
> WM8994 chip has built-in regulators, which might be used for chip
> operation. They are controlled by a separate wm8994-regulator driver,
> which should be loaded before this driver calls regulator_get(), because
> that driver also provides consumer-supply mapping for the them. If that
> driver is not yet loaded, regulator core substitute them with dummy
> regulator, what breaks chip operation, because the built-in regulators are
> never enabled. Fix this by annotating this driver with MODULE_SOFTDEP()
> "pre" dependency to "wm8994_regulator" module.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> ---
Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
Be good to ensure patches@...nsource.cirrus.com is CCed on
patches for the old Wolfson CODECs.
Thanks,
Charles
Powered by blists - more mailing lists