linux-kernel - Re: [PATCH v6 5/6] MIPS: DTS: JZ4780: define node for JZ4780 efuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1582815472.3.4@crapouillou.net>
Date:   Thu, 27 Feb 2020 11:57:52 -0300
From:   Paul Cercueil <paul@...pouillou.net>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>,
        Andreas Kemnade <andreas@...nade.info>,
        Mathieu Malaterre <malat@...ian.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com
Subject: Re: [PATCH v6 5/6] MIPS: DTS: JZ4780: define node for JZ4780 efuse

Hi Nikolaus,


Le mer., févr. 26, 2020 at 12:16, H. Nikolaus Schaller 
<hns@...delico.com> a écrit :
> From: PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
> 
> This patch brings support for the JZ4780 efuse. Currently it only 
> exposes
> a read only access to the entire 8K bits efuse memory and the
> ethernet mac address for the davicom dm9000 chip on the CI20 board.
> 
> It also changes the nemc reg range to avoid overlap.
> 
> Tested-by: Mathieu Malaterre <malat@...ian.org>
> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> ---
>  arch/mips/boot/dts/ingenic/jz4780.dtsi | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi 
> b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index f928329b034b..1e266be28096 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -358,7 +358,7 @@
> 
>  	nemc: nemc@...10000 {
>  		compatible = "ingenic,jz4780-nemc";
> -		reg = <0x13410000 0x10000>;
> +		reg = <0x13410000 0x4c>;

This is wrong, the real size of the register area is 1x15c.

>  		#address-cells = <2>;
>  		#size-cells = <1>;
>  		ranges = <1 0 0x1b000000 0x1000000
> @@ -373,6 +373,21 @@
>  		status = "disabled";
>  	};
> 
> +	efuse: efuse@...100d0 {
> +		compatible = "ingenic,jz4780-efuse";
> +		reg = <0x134100d0 0x2c>;
> +
> +		clocks = <&cgu JZ4780_CLK_AHB2>;
> +		clock-names = "ahb2";

As explained in my response to the other patch, 'clock-names' can go 
away.

Cheers,
-Paul

> +
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		eth0_addr: eth-mac-addr@...2 {
> +			reg = <0x22 0x6>;
> +		};
> +	};
> +
>  	dma: dma@...20000 {
>  		compatible = "ingenic,jz4780-dma";
>  		reg = <0x13420000 0x400
> --
> 2.23.0
>