linux-kernel - Re: [PATCH] power: supply: Allow charger manager can be built as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Feb 2020 00:06:17 +0800
From:   Orson Zhai <orsonzhai@...il.com>
To:     Baolin Wang <baolin.wang7@...il.com>
Cc:     sre@...nel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Lyra Zhang <zhang.lyra@...il.com>,
        kernel-team@...roid.com
Subject: Re: [PATCH] power: supply: Allow charger manager can be built as a module

Hi Sebastian and other guys here,

On Tue, Feb 11, 2020 at 4:51 PM Baolin Wang <baolin.wang7@...il.com> wrote:
>
> Allow charger manager can be built as a module like other charger
> drivers.
>
What do you think about this patch?
We want to set charger-manager as module in our project for new Android devices.

-Orson

> Signed-off-by: Baolin Wang <baolin.wang7@...il.com>
> ---
>  drivers/power/supply/Kconfig          |    2 +-
>  include/linux/power/charger-manager.h |    7 +------
>  2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 9a5591a..195bc04 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -480,7 +480,7 @@ config CHARGER_GPIO
>           called gpio-charger.
>
>  config CHARGER_MANAGER
> -       bool "Battery charger manager for multiple chargers"
> +       tristate "Battery charger manager for multiple chargers"
>         depends on REGULATOR
>         select EXTCON
>         help
> diff --git a/include/linux/power/charger-manager.h b/include/linux/power/charger-manager.h
> index ad19e68..40493b2 100644
> --- a/include/linux/power/charger-manager.h
> +++ b/include/linux/power/charger-manager.h
> @@ -248,11 +248,6 @@ struct charger_manager {
>         u64 charging_end_time;
>  };
>
> -#ifdef CONFIG_CHARGER_MANAGER
>  extern void cm_notify_event(struct power_supply *psy,
> -                               enum cm_event_types type, char *msg);
> -#else
> -static inline void cm_notify_event(struct power_supply *psy,
> -                               enum cm_event_types type, char *msg) { }
> -#endif
> +                           enum cm_event_types type, char *msg);
>  #endif /* _CHARGER_MANAGER_H */
> --
> 1.7.9.5
>