| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAL_JsqJno0gmUnGnsWFYdHY_3CHNijtksAmRhuEudimip0aK4w@mail.gmail.com>
Date: Thu, 27 Feb 2020 11:07:39 -0600
From: Rob Herring <robh+dt@...nel.org>
To: "Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@...ux.intel.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
linux-spi <linux-spi@...r.kernel.org>,
Mark Brown <broonie@...nel.org>, Vignesh R <vigneshr@...com>,
devicetree@...r.kernel.org, simon.k.r.goldschmidt@...il.com,
Dinh Nguyen <dinguyen@...nel.org>, tien.fong.chee@...el.com,
Marek Vašut <marex@...x.de>,
Mark Rutland <mark.rutland@....com>,
MTD Maling List <linux-mtd@...ts.infradead.org>,
David Woodhouse <dwmw2@...radead.org>,
Richard Weinberger <richard@....at>,
Brian Norris <computersforpeace@...il.com>,
Boris BREZILLON <boris.brezillon@...e-electrons.com>,
Cyrille Pitchen <cyrille.pitchen@...el.com>,
david.oberhollenzer@...ma-star.at,
Miquèl Raynal <miquel.raynal@...tlin.com>,
tudor.ambarus@...il.com, cheol.yong.kim@...el.com,
qi-ming.wu@...el.com
Subject: Re: [PATCH v11 1/2] dt-bindings: spi: Add schema for Cadence QSPI
Controller driver
On Thu, Feb 27, 2020 at 12:27 AM Ramuthevar,Vadivel MuruganX
<vadivel.muruganx.ramuthevar@...ux.intel.com> wrote:
>
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@...ux.intel.com>
>
> Add dt-bindings documentation for Cadence-QSPI controller to support
> spi based flash memories.
You need to run 'make dt_binding_check' because this doesn't pass.
>
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@...ux.intel.com>
> ---
> .../devicetree/bindings/mtd/cadence-quadspi.txt | 67 ----------
> .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 142 +++++++++++++++++++++
> 2 files changed, 142 insertions(+), 67 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mtd/cadence-quadspi.txt
> create mode 100644 Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> new file mode 100644
> index 000000000000..3ad2850c412e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> @@ -0,0 +1,142 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/spi/cdns,qspi-nor.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Cadence QSPI Flash Controller support
> +
> +maintainers:
> + - Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@...ux.intel.com>
> +
> +allOf:
> + - $ref: "spi-controller.yaml#"
> +
> +description: |
> + Binding Documentation for Cadence QSPI controller,This controller is
> + present in the Intel LGM, Altera SoCFPGA and TI SoCs and this driver
> + has been tested On Intel's LGM SoC.
> +
> + - compatible : should be one of the following:
> + Generic default - "cdns,qspi-nor".
> + For TI 66AK2G SoC - "ti,k2g-qspi", "cdns,qspi-nor".
> + For TI AM654 SoC - "ti,am654-ospi", "cdns,qspi-nor".
> + For Intel LGM SoC - "intel,lgm-qspi", "cdns,qspi-nor".
The schema below says all this, so drop this part.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - ti,k2g-qspi
> + - const: cdns,qspi-nor
> +
> + - items:
> + - enum:
> + - ti,am654-ospi
> + - const: cdns,qspi-nor
> +
> + - items:
> + - enum:
> + - intel,lgm-qspi
> + - const: cdns,qspi-nor
These 3 items can be 1 entry (combine the enums).
> +
> + - items:
> + - const: cdns,qspi-nor
> +
> + reg:
> + maxItems: 2
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + cdns,fifo-depth:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + 128 or 256 bytes size of the data FIFO in words.
Sounds like constraints. Make them a schema.
> +
> + cdns,fifo-width:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + 4 byte bus width of the data FIFO in bytes.
That's not very clear. It should be schema constraints anyways:
enum: [ 4, 8, 12, 16, ...??? ]
or:
multipleOf: 4
minimum: 4
maximum: ?
> +
> + cdns,trigger-address:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + 32-bit indirect AHB trigger address.
> +
> + cdns,rclk-en:
> + $ref: /schemas/types.yaml#/definitions/uint32
Wrong type if this is a 'flag' aka boolean.
> + description: |
> + Flag to indicate that QSPI return clock is used to latch the read data
> + rather than the QSPI clock. Make sure that QSPI return clock is populated
> + on the board before using this property.
> +
> +# subnode's properties
> +patternProperties:
> + "^.*@[0-9a-fA-F]+$":
> + type: object
> + description:
> + flash device uses the subnodes below defined properties.
> +
> + cdns,read-delay:
> + description:
> + Delay in 4 microseconds, read capture logic, in clock cycles.
Huh? Is it in time or clocks?
No unit suffix here, so this needs a type ref. That's what 'make
dt_binding_check' fails on.
> +
> + cdns,tshsl-ns:
> + description: |
> + Delay in 50 nanoseconds, for the length that the master mode chip select
> + outputs are de-asserted between transactions.
multipleOf: 50
And so on for the rest.
> +
> + cdns,tsd2d-ns:
> + description: |
> + Delay in 50 nanoseconds, between one chip select being de-activated
> + and the activation of another.
> +
> + cdns,tchsh-ns:
> + description: |
> + Delay in 4 nanoseconds, between last bit of current transaction and
> + deasserting the device chip select (qspi_n_ss_out).
> +
> + cdns,tslch-ns:
> + description: |
> + Delay in 4 nanoseconds, between setting qspi_n_ss_out low and
> + first bit transfer.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - cdns,fifo-depth
> + - cdns,fifo-width
> + - cdns,trigger-address
> +
> +examples:
> + - |
> + qspi: spi@...05000 {
> + compatible = "cdns,qspi-nor";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0xff705000 0x1000>,
> + <0xffa00000 0x1000>;
> + interrupts = <0 151 4>;
> + clocks = <&qspi_clk>;
> + cdns,fifo-depth = <128>;
> + cdns,fifo-width = <4>;
> + cdns,trigger-address = <0x00000000>;
> +
> + flash0: n25q00@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0x0>;
> + cdns,read-delay = <4>;
> + cdns,tshsl-ns = <50>;
> + cdns,tsd2d-ns = <50>;
> + cdns,tchsh-ns = <4>;
> + cdns,tslch-ns = <4>;
> + };
> + };
> +
> --
> 2.11.0
>
Powered by blists - more mailing lists