linux-kernel - Re: [PATCH -next] x86/jump_label: Fix old-style declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Feb 2020 21:45:00 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Borislav Petkov <bp@...en8.de>, YueHaibing <yuehaibing@...wei.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] x86/jump_label: Fix old-style declaration

On 1/2/20 1:36 AM, Borislav Petkov wrote:
> On Wed, Dec 25, 2019 at 07:45:00PM +0800, YueHaibing wrote:
>> Fix gcc warning:
>>
>> arch/x86/kernel/jump_label.c:61:1: warning:
>>  inline is not at beginning of declaration [-Wold-style-declaration]
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  arch/x86/kernel/jump_label.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
>> index 9c4498e..5ba8477 100644
>> --- a/arch/x86/kernel/jump_label.c
>> +++ b/arch/x86/kernel/jump_label.c
>> @@ -58,7 +58,7 @@ __jump_label_set_jump_code(struct jump_entry *entry, enum jump_label_type type,
>>  	return code;
>>  }
>>  
>> -static void inline __jump_label_transform(struct jump_entry *entry,
>> +static inline void __jump_label_transform(struct jump_entry *entry,
>>  					  enum jump_label_type type,
>>  					  int init)
>>  {
>> -- 
> 
> Looks not needed anymore:

I still see the warning.
Also I wonder what tree you tested the patch against?
Please see below.

> $ test-apply.sh /tmp/yuehaibing.01
> checking file arch/x86/kernel/jump_label.c
> Hunk #1 FAILED at 58.
> 1 out of 1 hunk FAILED
> Apply? (y/n) n
> --merge? (y/n) y
> patching file arch/x86/kernel/jump_label.c
> Hunk #1 NOT MERGED at 67-71.
> $ git diff
> diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
> index c1a8b9e71408..0a9e1dc65a3f 100644
> --- a/arch/x86/kernel/jump_label.c
> +++ b/arch/x86/kernel/jump_label.c
> @@ -64,7 +64,11 @@ static void __jump_label_set_jump_code(struct jump_entry *entry,
>                 memcpy(code, ideal_nop, JUMP_LABEL_NOP_SIZE);
>  }
>  
> +<<<<<<<
>  static void __ref __jump_label_transform(struct jump_entry *entry,

What tree has __ref in it?  I don't see that in linux-next or in tip.


> +=======
> +static inline void __jump_label_transform(struct jump_entry *entry,
> +>>>>>>>
>                                          enum jump_label_type type,
>                                          int init)
>  {
> 

thanks.
-- 
~Randy