linux-kernel - Re: [PATCH] power/supply: ingenic-battery: Don't print error on -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b90a4280727ee030fafb99a30a48c256@artur-rojek.eu>
Date:   Thu, 27 Feb 2020 22:00:39 +0100
From:   Artur Rojek <contact@...ur-rojek.eu>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Sebastian Reichel <sre@...nel.org>, od@...c.me,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power/supply: ingenic-battery: Don't print error on
 -EPROBE_DEFER

On 2020-02-21 01:58, Paul Cercueil wrote:
> Don't print an error message if devm_power_supply_register() returns
> -EPROBE_DEFER, since the driver will simply re-probe later.
Hi Paul.

This looks alright.

Acked-by: Artur Rojek <contact@...ur-rojek.eu>
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> ---
>  drivers/power/supply/ingenic-battery.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/ingenic-battery.c
> b/drivers/power/supply/ingenic-battery.c
> index 2748715c4c75..dd3d93dfe3eb 100644
> --- a/drivers/power/supply/ingenic-battery.c
> +++ b/drivers/power/supply/ingenic-battery.c
> @@ -148,7 +148,8 @@ static int ingenic_battery_probe(struct
> platform_device *pdev)
> 
>  	bat->battery = devm_power_supply_register(dev, desc, &psy_cfg);
>  	if (IS_ERR(bat->battery)) {
> -		dev_err(dev, "Unable to register battery\n");
> +		if (PTR_ERR(bat->battery) != -EPROBE_DEFER)
> +			dev_err(dev, "Unable to register battery\n");
>  		return PTR_ERR(bat->battery);
>  	}