linux-kernel - Re: [PATCH] dma-buf: free dmabuf->name in dma_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200227134541.82309165d59b3ce10848563a@linux-foundation.org>
Date:   Thu, 27 Feb 2020 13:45:41 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        LKML <linux-kernel@...r.kernel.org>,
        linaro-mm-sig@...ts.linaro.org,
        syzbot+b2098bc44728a4efb3e9@...kaller.appspotmail.com,
        Chenbo Feng <fengc@...gle.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH] dma-buf: free dmabuf->name in dma_buf_release()

On Thu, 27 Feb 2020 13:38:03 -0800 Cong Wang <xiyou.wangcong@...il.com> wrote:

> On Tue, Feb 25, 2020 at 5:54 PM Andrew Morton <akpm@...ux-foundation.org> wrote:
> >
> > On Tue, 25 Feb 2020 12:44:46 -0800 Cong Wang <xiyou.wangcong@...il.com> wrote:
> >
> > > dma-buff name can be set via DMA_BUF_SET_NAME ioctl, but once set
> > > it never gets freed.
> > >
> > > Free it in dma_buf_release().
> > >
> > > ...
> > >
> > > --- a/drivers/dma-buf/dma-buf.c
> > > +++ b/drivers/dma-buf/dma-buf.c
> > > @@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)
> > >               dma_resv_fini(dmabuf->resv);
> > >
> > >       module_put(dmabuf->owner);
> > > +     kfree(dmabuf->name);
> > >       kfree(dmabuf);
> > >       return 0;
> > >  }
> >
> > ow.  Is that ioctl privileged?
> 
> It looks unprivileged to me, as I don't see capable() called along
> the path.
> 

OK, thanks.  I added cc:stable to my copy.