linux-kernel - RE: [PATCH v1] ARM: dts: mihawk: Change the name of mihawk led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3633e9f58ab14118bf4c8df3f25ea0d2@wistron.com>
Date:   Thu, 27 Feb 2020 06:31:30 +0000
From:   <Ben_Pai@...tron.com>
To:     <joel@....id.au>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>, <andrew@...id.au>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-aspeed@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>,
        <wangat@...ibm.com>, <Claire_Ku@...tron.com>, <Ben_Pai@...tron.com>
Subject: RE: [PATCH v1] ARM: dts: mihawk: Change the name of mihawk led

Mihawk platform no longer supports these two LEDs, so I think these two LEDs should be removed from dts.

Signed-off-by: Ben Pai <Ben_Pai@...tron.com>

-----Original Message-----
From: Joel Stanley <joel@....id.au> 
Sent: Wednesday, February 26, 2020 6:56 PM
To: Ben Pai/WHQ/Wistron <Ben_Pai@...tron.com>
Cc: Rob Herring <robh+dt@...nel.org>; Mark Rutland <mark.rutland@....com>; Andrew Jeffery <andrew@...id.au>; devicetree <devicetree@...r.kernel.org>; Linux ARM <linux-arm-kernel@...ts.infradead.org>; linux-aspeed <linux-aspeed@...ts.ozlabs.org>; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>; wangat@...ibm.com; Claire Ku/WHQ/Wistron <Claire_Ku@...tron.com>
Subject: Re: [PATCH v1] ARM: dts: mihawk: Change the name of mihawk led

On Thu, 20 Feb 2020 at 05:53, Ben Pai <Ben_Pai@...tron.com> wrote:
>
> 1.Change the name of power, fault and rear-id.
> 2.Remove the two leds.

The patch looks okay. Why do you remove the other two leds?

Reviewed-by: Joel Stanley <joel@....id.au>

>
> Signed-off-by: Ben Pai <Ben_Pai@...tron.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts 
> b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> index e55cc454b17f..6c11854b9006 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts
> @@ -120,35 +120,24 @@
>         leds {
>                 compatible = "gpio-leds";
>
> -               fault {
> +               front-fault {
>                         retain-state-shutdown;
>                         default-state = "keep";
>                         gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_LOW>;
>                 };
>
> -               power {
> +               power-button {
>                         retain-state-shutdown;
>                         default-state = "keep";
>                         gpios = <&gpio ASPEED_GPIO(AA, 1) GPIO_ACTIVE_LOW>;
>                 };
>
> -               rear-id {
> +               front-id {
>                         retain-state-shutdown;
>                         default-state = "keep";
>                         gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_LOW>;
>                 };
>
> -               rear-g {
> -                       retain-state-shutdown;
> -                       default-state = "keep";
> -                       gpios = <&gpio ASPEED_GPIO(AA, 4) GPIO_ACTIVE_LOW>;
> -               };
> -
> -               rear-ok {
> -                       retain-state-shutdown;
> -                       default-state = "keep";
> -                       gpios = <&gpio ASPEED_GPIO(Y, 0) GPIO_ACTIVE_LOW>;
> -               };
>
>                 fan0 {
>                         retain-state-shutdown;
> --
> 2.17.1
>
>
> ----------------------------------------------------------------------
> ----------------------------------------------------------------------
> ------------------- This email contains confidential or legally 
> privileged information and is for the sole use of its intended recipient.
> Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.
> If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.
> ----------------------------------------------------------------------
> ----------------------------------------------------------------------
> -------------------