linux-kernel - Re: [PATCH] drivers/block/zram/zram_drv.c: avoid needless checks in backing_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200227081814.GI122464@google.com>
Date:   Thu, 27 Feb 2020 17:18:14 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Yue Hu <zbestahu@...il.com>
Cc:     minchan@...nel.org, ngupta@...are.org,
        sergey.senozhatsky.work@...il.com, axboe@...nel.dk,
        linux-kernel@...r.kernel.org, huyue2@...ong.com, zbestahu@....com
Subject: Re: [PATCH] drivers/block/zram/zram_drv.c: avoid needless checks in
 backing_dev_store() failure path

On (20/02/27 16:12), Yue Hu wrote:
> 
> There are null pointer checks in out block if backing_dev_store() fails.
> That is needless, we can avoid them by setting different jumping label.
> 

Dunno. Numerous error-out labels to jump to (instead of a single one)
don't really look like an improvement to me.

	-ss