linux-kernel - Re: [PATCH] net: core: devlink.c: Use built-in RCU list checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200226.165931.1079328769851545825.davem@davemloft.net>
Date:   Wed, 26 Feb 2020 16:59:31 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     madhuparnabhowmik10@...il.com
Cc:     jiri@...lanox.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, joel@...lfernandes.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        frextrite@...il.com, paulmck@...nel.org
Subject: Re: [PATCH] net: core: devlink.c: Use built-in RCU list checking

From: madhuparnabhowmik10@...il.com
Date: Tue, 25 Feb 2020 17:57:45 +0530

> From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> 
> list_for_each_entry_rcu() has built-in RCU and lock checking.
> 
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled.
> 
> The devlink->lock is held when devlink_dpipe_table_find()
> is called in non RCU read side section. Therefore, pass struct devlink
> to devlink_dpipe_table_find() for lockdep checking.
> 
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>

Applied, thank you.