[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200227131100.GB9899@kernel.org>
Date: Thu, 27 Feb 2020 10:11:00 -0300
From: Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To: Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
Cc: jolsa@...hat.com, xieyisheng1@...wei.com,
alexey.budankov@...ux.intel.com, treeze.taeung@...il.com,
adrian.hunter@...el.com, tmricht@...ux.ibm.com,
namhyung@...nel.org, irogers@...gle.com, songliubraving@...com,
yao.jin@...ux.intel.com, changbin.du@...el.com, leo.yan@...aro.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] perf annotate/tui: Re-render title bar after
switching back from script browser
Em Thu, Feb 13, 2020 at 12:12:59PM +0530, Ravi Bangoria escreveu:
> Perf annotate tui browser provides a hot key 'r' to switch to script
> browser. But the annotate browser title bar becomes hidden while
> switching back from script browser. Fix it.
Reproduced, tested fix, applied, thanks.
- Arnaldo
> Signed-off-by: Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
> ---
> tools/perf/ui/browsers/annotate.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
> index badbddbb30f8..0dbbf35e6ed1 100644
> --- a/tools/perf/ui/browsers/annotate.c
> +++ b/tools/perf/ui/browsers/annotate.c
> @@ -754,10 +754,9 @@ static int annotate_browser__run(struct annotate_browser *browser,
> "? Search string backwards\n");
> continue;
> case 'r':
> - {
> - script_browse(NULL, NULL);
> - continue;
> - }
> + script_browse(NULL, NULL);
> + annotate_browser__show(&browser->b, title, help);
> + continue;
> case 'k':
> notes->options->show_linenr = !notes->options->show_linenr;
> break;
> --
> 2.24.1
>
--
- Arnaldo
Powered by blists - more mailing lists