linux-kernel - RE: [PATCH v2 2/4] platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display() generic for platforms that support sub-states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR11MB362462D69BEA6CC2EEA42A64F2E80@BYAPR11MB3624.namprd11.prod.outlook.com>
Date:   Fri, 28 Feb 2020 17:33:30 +0000
From:   "Kammela, Gayatri" <gayatri.kammela@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Somayaji, Vishwanath" <vishwanath.somayaji@...el.com>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        "Westerberg, Mika" <mika.westerberg@...el.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "Prestopine, Charles D" <charles.d.prestopine@...el.com>,
        Chen Zhou <chenzhou10@...wei.com>,
        "Box, David E" <david.e.box@...el.com>
Subject: RE: [PATCH v2 2/4] platform/x86: intel_pmc_core: fix: Make
 pmc_core_lpm_display() generic for platforms that support sub-states


> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Friday, February 28, 2020 2:06 AM
> To: Kammela, Gayatri <gayatri.kammela@...el.com>
> Cc: platform-driver-x86@...r.kernel.org; linux-kernel@...r.kernel.org;
> Somayaji, Vishwanath <vishwanath.somayaji@...el.com>;
> dvhart@...radead.org; Westerberg, Mika <mika.westerberg@...el.com>;
> peterz@...radead.org; Prestopine, Charles D
> <charles.d.prestopine@...el.com>; Chen Zhou <chenzhou10@...wei.com>;
> Box, David E <david.e.box@...el.com>
> Subject: Re: [PATCH v2 2/4] platform/x86: intel_pmc_core: fix: Make
> pmc_core_lpm_display() generic for platforms that support sub-states
> 
> On Thu, Feb 27, 2020 at 03:29:14PM -0800, Gayatri Kammela wrote:
> > Currently pmc_core_lpm_display() uses array of struct pointers i.e.,
> > tgl_lpm_maps for Tiger Lake directly to iterate through and to get the
> > number of status/live status registers which is hardcoded and cannot
> > be re-used for future platforms that support sub-states. To maintain
> > readability, make pmc_core_lpm_display() generic, so that it can
> > re-used for future platforms.
> 
> This patch need more work, see below.
> That said, I would prefer to see it last in the series for next version.


Sure, I will put this patch last in the series in v3.

> 
> ...
> 
> > +	lpm_regs = kmalloc_array(arr_size, sizeof(*lpm_regs), GFP_KERNEL);
> 
> No error check?
> Besides that it is obvious memory leak.

Sorry my bad, I will put the check and free the memory. I will update this in v3

> 
> > +	for (index = 0; maps[index]; index++) {
> >  		lpm_regs[index] = pmc_core_reg_read(pmcdev, offset);
> >  		offset += 4;
> >  	}
> 
> --
> With Best Regards,
> Andy Shevchenko
>