linux-kernel - Re: [PATCH v4 13/13] powerpc/ptrace: move ptrace_triggered() into hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <95816cae-565b-40a8-a3bf-4733672c6e91@www.fastmail.com>
Date:   Fri, 28 Feb 2020 15:02:14 +1100
From:   "Russell Currey" <ruscur@...sell.cc>
To:     "Andrew Donnellan" <ajd@...ux.ibm.com>,
        "Michael Ellerman" <mpe@...erman.id.au>,
        "Christophe Leroy" <christophe.leroy@....fr>,
        "Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
        "Paul Mackerras" <paulus@...ba.org>, mikey@...ling.org
Cc:     linuxppc-dev@...ts.ozlabs.org,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 13/13] powerpc/ptrace: move ptrace_triggered() into hw_breakpoint.c

This was my fault, I should really test changes like these before they go live.  Apologies for the confusion caused

-- 
  Russell Currey
  ruscur@...sell.cc

On Fri, Feb 28, 2020, at 2:59 PM, Andrew Donnellan wrote:
> On 28/2/20 9:16 am, Michael Ellerman wrote:
> > Christophe Leroy <christophe.leroy@....fr> writes:
> >> Russel,
> >>
> >> Le 27/02/2020 à 12:49, Christophe Leroy a écrit :
> >>> ptrace_triggered() is declared in asm/hw_breakpoint.h and
> >>> only needed when CONFIG_HW_BREAKPOINT is set, so move it
> >>> into hw_breakpoint.c
> >>
> >> My series v4 is definitely buggy (I included ptrace_decl.h instead
> >> instead of ptrace-decl.h), how can Snowpatch say build succeeded
> >> (https://patchwork.ozlabs.org/patch/1245807/) ?
> > 
> > Which links to:
> >    https://openpower.xyz/job/snowpatch/job/snowpatch-linux-sparse/15895//artifact/linux/report.txt
> > 
> > The actual build log of which is:
> >    https://openpower.xyz/job/snowpatch/job/snowpatch-linux-sparse/15895/artifact/linux/build_new.log
> > 
> > Which contains:
> >    scripts/Makefile.build:267: recipe for target 'arch/powerpc/kernel/ptrace/ptrace-altivec.o' failed
> >    make[3]: *** [arch/powerpc/kernel/ptrace/ptrace-altivec.o] Error 1
> >    make[3]: *** Waiting for unfinished jobs....
> >    scripts/Makefile.build:505: recipe for target 'arch/powerpc/kernel/ptrace' failed
> >    make[2]: *** [arch/powerpc/kernel/ptrace] Error 2
> >    make[2]: *** Waiting for unfinished jobs....
> >    scripts/Makefile.build:505: recipe for target 'arch/powerpc/kernel' failed
> >    make[1]: *** [arch/powerpc/kernel] Error 2
> >    make[1]: *** Waiting for unfinished jobs....
> >    Makefile:1681: recipe for target 'arch/powerpc' failed
> >    make: *** [arch/powerpc] Error 2
> >    make: *** Waiting for unfinished jobs....
> > 
> > Same for ppc64le:
> >    https://openpower.xyz/job/snowpatch/job/snowpatch-linux-sparse/15896/artifact/linux/build_new.log
> > 
> > 
> > So it seems like snowpatch always reports the build as succeeded even
> > when it fails.
> 
> Turns out there was an issue in a recent change in our build script 
> which caused build failures to return the wrong exit code and put the 
> wrong text in the reports, because of some confusion with bash 
> subshells. I've fixed it (I think).
> 
> -- 
> Andrew Donnellan              OzLabs, ADL Canberra
> ajd@...ux.ibm.com             IBM Australia Limited
> 
>