linux-kernel - Re: [PATCH] parport: fix if-statement empty body warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69fb1d36-b6cf-7c46-96d1-9403de6ab47a@infradead.org>
Date:   Thu, 27 Feb 2020 20:19:26 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Joe Perches <joe@...ches.com>, LKML <linux-kernel@...r.kernel.org>,
        linux-parport@...ts.infradead.org
Cc:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
Subject: Re: [PATCH] parport: fix if-statement empty body warnings

On 2/27/20 7:19 PM, Joe Perches wrote:
> Eliminate warnings by using pr_debug which is the more typical
> kernel debugging style and also enable dynamic_debug on these
> outputs.
> 
> Miscellaneous:
> 
> o A few messages were logged at KERN_INFO when enabled, now KERN_DEBUG
> o Convert %d/%d to %zd/%zu to avoid compilation warnings
> 
> Original-patch-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Joe Perches <joe@...ches.com>
> Acked-by: Randy Dunlap <rdunlap@...radead.org>
> ---
>  drivers/parport/ieee1284.c     | 90 ++++++++++++++++--------------------------
>  drivers/parport/ieee1284_ops.c | 67 +++++++++++--------------------
>  2 files changed, 57 insertions(+), 100 deletions(-)

Thanks, Joe.

-- 
~Randy