linux-kernel - Re: [PATCH][next] Bluetooth: Replace zero-length array with flexible-array member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1E945B13-0BCB-4908-BA32-87DC0F982154@holtmann.org>
Date:   Fri, 28 Feb 2020 08:32:10 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Bluez mailing list <linux-bluetooth@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH][next] Bluetooth: Replace zero-length array with
 flexible-array member

Hi Gustavo,

> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
> 
> struct foo {
>        int stuff;
>        struct boo array[];
> };
> 
> By making use of the mechanism above, we will get a compiler warning
> in case the flexible array does not occur last in the structure, which
> will help us prevent some kind of undefined behavior bugs from being
> inadvertently introduced[3] to the codebase from now on.
> 
> Also, notice that, dynamic memory allocations won't be affected by
> this change:
> 
> "Flexible array members have incomplete type, and so the sizeof operator
> may not be applied. As a quirk of the original implementation of
> zero-length arrays, sizeof evaluates to zero."[1]
> 
> This issue was found with the help of Coccinelle.
> 
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
> drivers/bluetooth/btqca.h        |  6 +++---
> drivers/bluetooth/btrtl.h        |  4 ++--
> include/net/bluetooth/hci.h      | 30 +++++++++++++++---------------
> include/net/bluetooth/hci_sock.h |  6 +++---
> include/net/bluetooth/l2cap.h    |  8 ++++----
> include/net/bluetooth/rfcomm.h   |  2 +-
> net/bluetooth/a2mp.h             | 10 +++++-----
> net/bluetooth/bnep/bnep.h        |  6 +++---
> 8 files changed, 36 insertions(+), 36 deletions(-)

Patch has been applied to bluetooth-next tree.

Regards

Marcel