linux-kernel - Re: [PATCH] net: ieee802154: ca8210: Use new structure for SPI transfer delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Feb 2020 09:41:48 +0100
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Sergiu Cuciurean <sergiu.cuciurean@...log.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-wpan@...r.kernel.org, davem@...emloft.net,
        alex.aring@...il.com, h.morris@...coda.com
Subject: Re: [PATCH] net: ieee802154: ca8210: Use new structure for SPI
 transfer delays

Hello.

On 27.02.20 14:12, Sergiu Cuciurean wrote:
> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@...log.com>
> ---
>   drivers/net/ieee802154/ca8210.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index 430c93786153..e04c3b60cae7 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -946,7 +946,8 @@ static int ca8210_spi_transfer(
>   	cas_ctl->transfer.bits_per_word = 0; /* Use device setting */
>   	cas_ctl->transfer.tx_buf = cas_ctl->tx_buf;
>   	cas_ctl->transfer.rx_buf = cas_ctl->tx_in_buf;
> -	cas_ctl->transfer.delay_usecs = 0;
> +	cas_ctl->transfer.delay.value = 0;
> +	cas_ctl->transfer.delay.unit = SPI_DELAY_UNIT_USECS;
>   	cas_ctl->transfer.cs_change = 0;
>   	cas_ctl->transfer.len = sizeof(struct mac_message);
>   	cas_ctl->msg.complete = ca8210_spi_transfer_complete;
> 


This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt