linux-kernel - Re: [PATCH v10 2/5] dt-bindings: mediatek: Update mmsys binding to reflect it is a system controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Feb 2020 17:19:45 +0800
From:   CK Hu <ck.hu@...iatek.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>,
        <p.zabel@...gutronix.de>, <airlied@...ux.ie>,
        <mturquette@...libre.com>, <sboyd@...nel.org>,
        <ulrich.hecht+renesas@...il.com>,
        <laurent.pinchart@...asonboard.com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        <rdunlap@...radead.org>, <dri-devel@...ts.freedesktop.org>,
        Weiyi Lu <weiyi.lu@...iatek.com>,
        "Seiya Wang" <seiya.wang@...iatek.com>,
        <linux-clk@...r.kernel.org>,
        "Collabora Kernel ML" <kernel@...labora.com>,
        mtk01761 <wendell.lin@...iatek.com>,
        Allison Randal <allison@...utok.net>,
        Thomas Gleixner <tglx@...utronix.de>, <wens@...e.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Houlong Wei <houlong.wei@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-media@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <sean.wang@...iatek.com>, <frank-w@...lic-files.de>,
        Minghsiu Tsai <minghsiu.tsai@...iatek.com>,
        Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
        <linux-mediatek@...ts.infradead.org>, <hsinyi@...omium.org>,
        Matthias Brugger <mbrugger@...e.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        Richard Fontana <rfontana@...hat.com>,
        <linux-kernel@...r.kernel.org>, <matthias.bgg@...nel.org>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH v10 2/5] dt-bindings: mediatek: Update mmsys binding to
 reflect it is a system controller

Hi, Enric:

On Thu, 2020-02-27 at 19:08 +0100, Enric Balletbo i Serra wrote:
> The mmsys system controller is not only a pure clock controller, so
> update the binding documentation to reflect that apart from providing
> clocks, it also provides routing and miscellaneous control registers.
> 

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
> 
> Changes in v10:
> - Update the binding documentation for the mmsys system controller.
> 
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> 
>  .../devicetree/bindings/arm/mediatek/mediatek,mmsys.txt    | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> index 301eefbe1618..8d6a9d98e7a6 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> @@ -1,7 +1,8 @@
>  Mediatek mmsys controller
>  ============================
>  
> -The Mediatek mmsys controller provides various clocks to the system.
> +The Mediatek mmsys system controller provides clock control, routing control,
> +and miscellaneous control in mmsys partition.
>  
>  Required Properties:
>  
> @@ -15,13 +16,13 @@ Required Properties:
>  	- "mediatek,mt8183-mmsys", "syscon"
>  - #clock-cells: Must be 1
>  
> -The mmsys controller uses the common clk binding from
> +For the clock control, the mmsys controller uses the common clk binding from
>  Documentation/devicetree/bindings/clock/clock-bindings.txt
>  The available clocks are defined in dt-bindings/clock/mt*-clk.h.
>  
>  Example:
>  
> -mmsys: clock-controller@...00000 {
> +mmsys: syscon@...00000 {
>  	compatible = "mediatek,mt8173-mmsys", "syscon";
>  	reg = <0 0x14000000 0 0x1000>;
>  	#clock-cells = <1>;