[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200228093923.GC27860@amd>
Date: Fri, 28 Feb 2020 10:39:23 +0100
From: Pavel Machek <pavel@...x.de>
To: Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc: Dan Murphy <dmurphy@...com>, Greg KH <gregkh@...uxfoundation.org>,
Pavel Machek <pavel@...x.de>, linux-leds@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v17 00/17] Multi Color LED Framework
Hi!
> >> Writing 3 or 4 or 5 numbers all at once in a single sysfs file to
> >> represent a single output should be fine.
> >> thanks,
>
> Thank you for making this clear.
>
> Effectively, the way to go as I see it now is just moving from
> colors directory to channel_intensity and channel_names files.
Yes.
> Besides that, since the issue of backwards compatibility with
> LED class still remains, we need to apply the already worked out
> formula for mapping brightness to color iout values.
>
> This implies that color values written to channel_intensity file
> will be written unchanged to the hw only when global brightness
> is equal to max_brightness. This is because they will be multiplied
> by brightness / max_brightness ratio.
>
> Do you agree, Pavel?
Yes. That seems like possible solution.
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)
Powered by blists - more mailing lists