linux-kernel - Re: [PATCH] KVM: nVMX: Consult only the "basic" exit reason when routing nested exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Feb 2020 10:57:30 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>,
        Krish Sadhukhan <krish.sadhukhan@...cle.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xiaoyao Li <xiaoyao.li@...el.com>
Subject: Re: [PATCH] KVM: nVMX: Consult only the "basic" exit reason when
 routing nested exit

On 27/02/20 21:51, Sean Christopherson wrote:
> So part of me thinks the best way to resolve the printing would be to
> modify VMX_EXIT_REASONS to do "| VMX_EXIT_REASONS_FAILED_VMENTRY" where
> appropriate, i.e. on INVALID_STATE, MSR_LOAD_FAIL and MCE_DURING_VMENTRY.
> The downside of that approach is it breaks again when new modifiers come
> along, e.g. SGX's ENCLAVE_EXIT.  But again, the modifier is likely useful
> information.
> 
> I think the most foolproof and informative way to handle this would be to
> add a macro and/or helper function, e.g. kvm_print_vmx_exit_reason(), to
> wrap __print_symbolic(__entry->exit_code, VMX_EXIT_REASONS) so that it
> prints both the name of the basic exit reason as well as the names for
> any modifiers.
> 
> TL;DR: I still like this patch as is, especially since it'll be easy to
> backport.  I'll send a separate patch for the tracepoint issue.

Agreed, thanks.  I queued this one.

Paolo